Code Review: MySQLDAO.java

(DRY, bottom-up programming)

The Code

Today's review is of a Java class called MySQLDAO.java:


Code Review: Constants.pm

(cohesion, scope, laziness)

The Code

Today I took home a chunk of code to review. It's a chunk of code which I've run across, in one form or another, for 10 years now, and it drives me around the bend. In Perl: Constants.pm. In Java: Constants.java. In C/C++: constants.h.

Let's have a look at the perl module KitchenSink/Constants.pm: